Skip to content

improve the gathering of names in MultiUsernameFilterField #6594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

improve the gathering of names in MultiUsernameFilterField #6594

merged 1 commit into from
Mar 26, 2025

Conversation

escattone
Copy link
Contributor

@escattone escattone requested a review from smithellis March 26, 2025 20:39
smithellis
smithellis requested changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@smithellis smithellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this exposes a bug elsewhere in the lookup process - you can now search for SumoBot but not SuMo Bot.

@escattone
Copy link
Contributor Author

I think this exposes a bug elsewhere in the lookup process - you can now search for SumoBot but not SuMo Bot.

Hm, I did test SuMo Bot and it worked. In fact, that's why @emilghittasv created mozilla/sumo#2277.

smithellis
smithellis approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@smithellis smithellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing works, this is perfect. Thanks!

@escattone escattone merged commit 5541ea3 into mozilla:main Mar 26, 2025
2 checks passed
@escattone escattone deleted the fix-2277 branch March 26, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smithellis smithellis smithellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@escattone @smithellis